Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the as property in the CHeader component to use semantic tag #290

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add the as property in the CHeader component to use semantic tag #290

merged 1 commit into from
Jul 30, 2024

Conversation

cesargb
Copy link
Contributor

@cesargb cesargb commented May 31, 2024

The component CHeader write the tag div, with this custom property we can use header tag

<CHeader> ... </CHeader>
// Out put: <div class="header"> ... </div>

<CHeader as="header"> ... </CHeader>
// Out put: <header class="header"> ... </header>

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

@mrholek mrholek merged commit 839a2bc into coreui:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrholek mrholek mrholek approved these changes

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cesargb @mrholek